All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Daniel Toussaint <daniel@dmhome.net>
Cc: linux-acpi@vger.kernel.org
Subject: Re: Driver for handling SCI interrupt.
Date: Thu, 9 Feb 2012 12:36:02 +0000	[thread overview]
Message-ID: <20120209123601.GA27943@srcf.ucam.org> (raw)
In-Reply-To: <CADVYk4T3wAjE3qFFynbmnceLeNFSRb+M+Lq6qw2c9ncGJS6V9g@mail.gmail.com>

On Thu, Feb 09, 2012 at 01:24:02PM +0800, Daniel Toussaint wrote:
> Thanks very much for the very helpful info.
> I have added the GPE to my DSDT and now I can see the GPE counter in
> /sys/firmware/acpi/interrupts increasing whenever I send an SCI.
> Further more, I  found the function acpi_install_gpe_handler in the
> kernel, and used it successfully to install a handler in a temporary
> driver I created.
> My custom device is an I2C device that I will read input from ,
> whenever my gpe event occurs. Now my question is : this seems to work
> without declaring a new device in the DSDT , with an HID - as you
> mentioned - so can I get away with doing things this way , or would it
> be bad practice ?

Well, if it works, you can obviously do it without any further 
modification :) It would arguably be more "correct" to define it as a 
full ACPI device - that way you can have module autoloading and 
automatic resource discovery. But if you're happy with a static 
configuration then just go with what you have now.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      reply	other threads:[~2012-02-09 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06  3:25 Driver for handling SCI interrupt Daniel Toussaint
2012-02-06 14:57 ` Matthew Garrett
2012-02-09  5:24   ` Daniel Toussaint
2012-02-09 12:36     ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209123601.GA27943@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=daniel@dmhome.net \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.