From: Paul Brook <paul@codesourcery.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Dmitry Solodkiy <d.solodkiy@samsung.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after
Date: Thu, 9 Feb 2012 13:18:03 +0000 [thread overview]
Message-ID: <201202091318.04031.paul@codesourcery.com> (raw)
In-Reply-To: <4F33BD5F.3040901@suse.de>
> Am 09.02.2012 13:15, schrieb Paul Brook:
> >> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
> >> were accidentally trying to set one of the arm_sysctl properties
> >> after device init. This has now become a fatal error; set the property
> >> before device init where it should be done instead.
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >> ---
> >> If somebody would like to commit this simple patch quickly that would
> >> probably be a good idea since these models are otherwise totally
> >> broken...
> >
> > Done.
>
> Your commit should've contained Paolo's Reviewed-by tag after Peter's
> SoB,
Ok.
> and you as committer didn't sign it off either.
Ah, I thought SoB was only relevant if I'd actually touched the patch.
Paul
prev parent reply other threads:[~2012-02-09 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 6:11 [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after Peter Maydell
2012-02-09 9:23 ` Paolo Bonzini
2012-02-09 12:15 ` Paul Brook
2012-02-09 12:34 ` Andreas Färber
2012-02-09 12:37 ` Andreas Färber
2012-02-09 13:18 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202091318.04031.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.