All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW_DM libdm/libdm-deptree.c
Date: 10 Feb 2012 14:48:31 -0000	[thread overview]
Message-ID: <20120210144831.20341.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2012-02-10 14:48:30

Modified files:
	.              : WHATS_NEW_DM 
	libdm          : libdm-deptree.c 

Log message:
	Check for deps pointer before dererence
	
	As _deps() call may return NULL - check for it.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.547&r2=1.548
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.155&r2=1.156

--- LVM2/WHATS_NEW_DM	2012/02/10 14:42:28	1.547
+++ LVM2/WHATS_NEW_DM	2012/02/10 14:48:28	1.548
@@ -1,6 +1,7 @@
 Version 1.02.70 - 
 ===================================
-  Validate name and uuid params of dm_tree_add_new_dev_with_udev_flags().  
+  Add pointer test for dependency check in _add_dev().
+  Validate name and uuid params of dm_tree_add_new_dev_with_udev_flags().
   Do not crash for dm_report_init() sort_key == NULL and behave like "".
   Return error for failing allocation in dm_asprintf().
   Add missing test for failing allocation in dm_realloc() code.
--- LVM2/libdm/libdm-deptree.c	2012/02/10 14:42:28	1.155
+++ LVM2/libdm/libdm-deptree.c	2012/02/10 14:48:28	1.156
@@ -1180,7 +1180,7 @@
 		goto out;
 
 	/* Can't recurse if not a mapped device or there are no dependencies */
-	if (!node->info.exists || !deps->count) {
+	if (!node->info.exists || !deps || !deps->count) {
 		if (!_add_to_bottomlevel(node)) {
 			stack;
 			node = NULL;



             reply	other threads:[~2012-02-10 14:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 14:48 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-15 21:27 LVM2 ./WHATS_NEW_DM libdm/libdm-deptree.c agk
2012-02-10 14:42 zkabelac
2012-01-25 21:50 zkabelac
2011-10-17 13:15 mbroz
2011-10-14 13:34 zkabelac
2011-10-03 18:28 zkabelac
2011-09-07  8:37 zkabelac
2011-02-18 16:13 zkabelac
2009-07-03 12:45 agk
2008-12-11 16:25 zkabelac
2008-12-11 16:35 ` Dave Wysochanski
2008-12-12  0:07   ` Alasdair G Kergon
2008-12-12  9:26   ` Zdenek Kabelac
2008-12-12 13:29     ` Dave Wysochanski
2008-12-12 14:00       ` Zdenek Kabelac
2008-12-12  0:02 ` Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210144831.20341.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.