From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [RFC] need to improve slot creation/destruction? -- Re: [RFC][PATCH] srcu: Implement call_srcu()
Date: Fri, 10 Feb 2012 22:25:13 +0900 [thread overview]
Message-ID: <20120210222513.7a8919f2f73604ca25c58bbd@gmail.com> (raw)
In-Reply-To: <4F33D6C9.2070403@redhat.com>
Avi Kivity <avi@redhat.com> wrote:
> > 2. When we create(and shift?) a memory slot, we call kvm_arch_flush_shadow()
> > to clear all mmio sptes, again not restricted to that slot.
> >
> > /*
> > * If the new memory slot is created, we need to clear all
> > * mmio sptes.
> > */
> > if (npages && old.base_gfn != mem->guest_phys_addr >> PAGE_SHIFT)
> > kvm_arch_flush_shadow(kvm);
>
> This is pretty rare outside the previous scenario (memory/pci hotplug).
Is this condition correct?
When npages != 0 and old.npages == 0, the slot is being newly created, do we
really need to flush shadow pages?
This should be
if (npages && old.npages && (old.base_gfn != base_gfn))
No?
Takuya
next prev parent reply other threads:[~2012-02-10 13:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 13:32 [RFC][PATCH] srcu: Implement call_srcu() Peter Zijlstra
2012-01-31 13:47 ` Avi Kivity
2012-01-31 13:50 ` Peter Zijlstra
2012-01-31 22:24 ` Paul E. McKenney
2012-02-01 10:22 ` Peter Zijlstra
2012-02-01 10:44 ` Avi Kivity
2012-02-01 10:49 ` Avi Kivity
2012-02-01 11:00 ` Takuya Yoshikawa
2012-02-01 11:01 ` Avi Kivity
2012-02-01 11:12 ` Takuya Yoshikawa
2012-02-01 13:24 ` Avi Kivity
2012-02-02 5:46 ` [test result] dirty logging without srcu update -- " Takuya Yoshikawa
2012-02-02 10:10 ` Avi Kivity
2012-02-02 10:21 ` Takuya Yoshikawa
2012-02-02 10:21 ` Avi Kivity
2012-02-02 10:40 ` Takuya Yoshikawa
2012-02-02 11:02 ` Avi Kivity
2012-02-02 14:44 ` Takuya Yoshikawa
2012-02-02 14:57 ` Avi Kivity
2012-02-01 13:43 ` Marcelo Tosatti
2012-02-01 15:42 ` Takuya Yoshikawa
2012-02-01 13:50 ` Marcelo Tosatti
2012-02-08 15:43 ` [RFC] need to improve slot creation/destruction? -- " Takuya Yoshikawa
2012-02-08 18:45 ` Marcelo Tosatti
2012-02-09 13:48 ` Takuya Yoshikawa
2012-02-09 14:25 ` Avi Kivity
2012-02-10 17:16 ` Marcelo Tosatti
2012-02-14 9:52 ` Avi Kivity
2012-02-09 14:23 ` Avi Kivity
2012-02-09 14:24 ` Avi Kivity
2012-02-10 13:08 ` Takuya Yoshikawa
2012-02-10 17:17 ` Marcelo Tosatti
2012-02-10 13:25 ` Takuya Yoshikawa [this message]
2012-02-14 9:52 ` Avi Kivity
2012-02-01 14:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210222513.7a8919f2f73604ca25c58bbd@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.