All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
Date: Sat, 11 Feb 2012 17:24:16 +0100	[thread overview]
Message-ID: <201202111724.16231.arnout@mind.be> (raw)
In-Reply-To: <CAAXf6LV1gHy+w2N3T_xz+iETCdANPsJNMefR-XBLM8FqCKA9Lw@mail.gmail.com>

On Friday 10 February 2012 17:41:04 Thomas De Schampheleire wrote:
> >> Is there a particular reason why you changed this?
> >>
> >> And to other buildroot developers: what is the policy regarding
> >> directly specifying CC and LD, instead of using variables like
> >> TARGET_CONFIGURE_OPTS ?
> >>
> >
> > Yes, I changed that line since usb_modeswitch would not compile. I was
> > following the example from:
> > http://buildroot.uclibc.org/buildroot.html#generic-tutorial
> >
> > Please let me know how or what you want changed, and I will re-submit.
> 
> I checked and this is caused because your Makefile patch removed the
> CC ?= gcc
> change.
> 
> Personally I don't mind your solution, as it is one less change to the
> Makefile.
> For me, you don't need to change it.

 J.C.'s solution is preferred, I would say.

- It doesn't require patching.

- It's how it is documented.

- TARGET_CONFIGURE_OPTIONS is meant for autoconf.

- This will be the way that the MAKETARGETS infrastructure will be 
implemented.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-02-11 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 23:42 [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3 J.C. Woltz
2012-02-10  7:29 ` Thomas De Schampheleire
2012-02-10 14:28   ` J.C. Woltz
2012-02-10 16:41     ` Thomas De Schampheleire
2012-02-11 16:24       ` Arnout Vandecappelle [this message]
2012-02-11 16:30 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202111724.16231.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.