From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write
Date: Sun, 12 Feb 2012 13:11:05 +0000 [thread overview]
Message-ID: <20120212131101.GA3395@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F37A925.90507@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Sun, Feb 12, 2012 at 12:57:25PM +0100, Lars-Peter Clausen wrote:
> On 02/12/2012 09:49 AM, Laxman Dewangan wrote:
> > [...]
> > + } else {
> > + for (i = 0; i < val_count; i++) {
> > + memcpy(&ival, val + (i * val_bytes), val_bytes);
> This will have endianess issues. You'll need something like regcache_get_val.
> > + ret = _regmap_write(map, reg + i, ival);
Or just don't provide this fallback at all - it's not something the
underlying device supports anyway and none of the other block or bulk
operations work on these devices either.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-12 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 8:49 [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write Laxman Dewangan
2012-02-12 8:49 ` Laxman Dewangan
[not found] ` <1329036556-15408-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-12 11:57 ` Lars-Peter Clausen
2012-02-12 11:57 ` Lars-Peter Clausen
2012-02-12 13:11 ` Mark Brown [this message]
[not found] ` <20120212131101.GA3395-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-02-12 14:14 ` Laxman Dewangan
2012-02-12 14:14 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120212131101.GA3395@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.