From: Amit Shah <amit.shah@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, johnstul@us.ibm.com,
riel@redhat.com, avi@redhat.com, imammedo@redhat.com
Subject: Re: x86: kvmclock: abstract save/restore sched_clock_state (v2)
Date: Mon, 13 Feb 2012 21:56:50 +0530 [thread overview]
Message-ID: <20120213162650.GB28343@amit.redhat.com> (raw)
In-Reply-To: <20120213130727.GA8052@amt.cnet>
On (Mon) 13 Feb 2012 [11:07:27], Marcelo Tosatti wrote:
>
> Upon resume from hibernation, CPU 0's hvclock area contains the old
> values for system_time and tsc_timestamp. It is necessary for the
> hypervisor to update these values with uptodate ones before the CPU uses
> them.
>
> Abstract TSC's save/restore sched_clock_state functions and use
> restore_state to write to KVM_SYSTEM_TIME MSR, forcing an update.
>
> Also move restore_sched_clock_state before __restore_processor_state,
> since the later calls CONFIG_LOCK_STAT's lockstat_clock (also for TSC).
> Thanks to Igor Mammedov for tracking it down.
>
> Fixes suspend-to-disk with kvmclock.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
This works fine, thanks.
Tested-by: Amit Shah <amit.shah@redhat.com>
Amit
next prev parent reply other threads:[~2012-02-13 16:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 21:05 x86: kvmclock: abstract save/restore sched_clock_state Marcelo Tosatti
2012-02-08 10:53 ` Igor Mammedov
2012-02-09 12:27 ` Amit Shah
2012-02-09 15:13 ` Igor Mammedov
2012-02-10 10:02 ` Amit Shah
2012-02-10 10:11 ` Igor Mammedov
2012-02-10 10:23 ` Amit Shah
2012-02-10 12:32 ` Marcelo Tosatti
2012-02-10 12:33 ` Marcelo Tosatti
2012-02-10 12:43 ` Igor Mammedov
2012-02-13 12:46 ` Amit Shah
2012-02-13 12:56 ` Amit Shah
2012-02-10 13:18 ` Amit Shah
2012-02-10 20:58 ` Igor Mammedov
2012-02-13 12:39 ` Amit Shah
2012-02-13 13:07 ` x86: kvmclock: abstract save/restore sched_clock_state (v2) Marcelo Tosatti
2012-02-13 15:20 ` Igor Mammedov
2012-02-13 15:52 ` Marcelo Tosatti
2012-02-15 10:28 ` Avi Kivity
2012-02-13 15:45 ` [PATCH RFC] pvclock: Make pv_clock more robust and fixup it if overflow happens Igor Mammedov
2012-02-13 17:48 ` Marcelo Tosatti
2012-02-13 18:15 ` Igor Mammedov
2012-02-13 16:26 ` Amit Shah [this message]
2012-03-01 9:58 ` x86: kvmclock: abstract save/restore sched_clock_state Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213162650.GB28343@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.