From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: [PATCH] modpost: Fix section warnings for ARM for many compilers Date: Mon, 13 Feb 2012 13:24:01 -0800 Message-ID: <20120213212401.GH1426@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Rusty Russell , Ben Hutchings , Anders Kaseorg , Greg KH , Russell King List-Id: linux-omap@vger.kernel.org It turns out that many compilers don't show section warnings on ARM currently because handling for ARM_CALL relocs are missing from modpost.c. Based on commit c2e26114 ([ARM] 3205/1: Handle new EABI relocations when loading kernel modules) it seems that R_ARM_PC24, R_ARM_CALL and R_ARM_JUMP24 can be handled the same way. As modpost.c includes elf.h, we need to also consider that at least Debian libc6-dev is missing defines for both R_ARM_CALL and R_ARM_JUMP24 in /usr/include/elf.h. So for now let's just use the numbers in modpost.c. Cc: Rusty Russell Cc: Ben Hutchings Cc: Anders Kaseorg Cc: Greg KH Cc: Russell King Signed-off-by: Tony Lindgren --- Anybody got better ideas for dealing with the missing elf.h defines? --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1505,6 +1505,8 @@ static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) (elf->symtab_start + ELF_R_SYM(r->r_info)); break; case R_ARM_PC24: + case 28: /* R_ARM_CALL */ + case 29: /* R_ARM_JUMP24 */ /* From ARM ABI: ((S + A) | T) - P */ r->r_addend = (int)(long)(elf->hdr + sechdr->sh_offset + From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 13 Feb 2012 13:24:01 -0800 Subject: [PATCH] modpost: Fix section warnings for ARM for many compilers Message-ID: <20120213212401.GH1426@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org It turns out that many compilers don't show section warnings on ARM currently because handling for ARM_CALL relocs are missing from modpost.c. Based on commit c2e26114 ([ARM] 3205/1: Handle new EABI relocations when loading kernel modules) it seems that R_ARM_PC24, R_ARM_CALL and R_ARM_JUMP24 can be handled the same way. As modpost.c includes elf.h, we need to also consider that at least Debian libc6-dev is missing defines for both R_ARM_CALL and R_ARM_JUMP24 in /usr/include/elf.h. So for now let's just use the numbers in modpost.c. Cc: Rusty Russell Cc: Ben Hutchings Cc: Anders Kaseorg Cc: Greg KH Cc: Russell King Signed-off-by: Tony Lindgren --- Anybody got better ideas for dealing with the missing elf.h defines? --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1505,6 +1505,8 @@ static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) (elf->symtab_start + ELF_R_SYM(r->r_info)); break; case R_ARM_PC24: + case 28: /* R_ARM_CALL */ + case 29: /* R_ARM_JUMP24 */ /* From ARM ABI: ((S + A) | T) - P */ r->r_addend = (int)(long)(elf->hdr + sechdr->sh_offset +