All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, Manish Katiyar <mkatiyar@gmail.com>
Subject: Re: [PATCH 1/3] jbd2: allocate transaction from special cache
Date: Mon, 13 Feb 2012 17:10:20 -0500	[thread overview]
Message-ID: <20120213221020.GB21641@thunk.org> (raw)
In-Reply-To: <1321183291-4589-1-git-send-email-xiaoqiangnk@gmail.com>

On Sun, Nov 13, 2011 at 07:21:29PM +0800, Yongqiang Yang wrote:
> transaction_t is 136 byes under 32-bit systems. If we allocate
> it from general cache, it comsumes 256 bytes.  So let jbd2 allocate
> it from special cache to reduce memory consumption.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>

Thanks, applied with a modified description:

    jbd2: allocate transaction from separate slab cache
    
    There is normally only a handful of these active at any one time, but
    putting them in a separate slab cache makes debugging memory
    corruption problems easier.  Manish Katiyar also wanted this make it
    easier to test memory failure scenarios in the jbd2 layer.

    	      	   	  	  	       - Ted

      parent reply	other threads:[~2012-02-13 22:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 11:21 [PATCH 1/3] jbd2: allocate transaction from special cache Yongqiang Yang
2011-11-13 11:21 ` [PATCH 2/3] jbd2: rename functions initializing caches Yongqiang Yang
2012-02-13 22:10   ` Ted Ts'o
2011-11-13 11:21 ` [PATCH 3/3] jbd2: use KMEM_CACHE instead of kmem_cache_create Yongqiang Yang
2012-02-13 22:10   ` Ted Ts'o
2012-02-13 22:10 ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120213221020.GB21641@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.