From: Ted Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 2/3] ext4: remove unnecessary assignments in xattr.c
Date: Mon, 13 Feb 2012 18:21:04 -0500 [thread overview]
Message-ID: <20120213232104.GH21641@thunk.org> (raw)
In-Reply-To: <1320672724-4432-3-git-send-email-wenqing.lz@taobao.com>
On Mon, Nov 07, 2011 at 09:32:03PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In some functions, 'error' variable is assigned but not used when the result
> of if statement is false.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
I really wouldn't worry about this. It increases the size of both the
source and the binary, and if there are architectures where registers
are especially precious, it's easy enough for the compiler to optimize
appropriately.
- Ted
next prev parent reply other threads:[~2012-02-13 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 13:32 [PATCH 0/3] ext4: cleanup xattr stuff Zheng Liu
2011-11-07 13:32 ` [PATCH 1/3] ext4: remove 'error' variable in ext4_xattr_check_block() Zheng Liu
2012-02-13 23:04 ` Ted Ts'o
2011-11-07 13:32 ` [PATCH 2/3] ext4: remove unnecessary assignments in xattr.c Zheng Liu
2012-02-13 23:21 ` Ted Ts'o [this message]
2011-11-07 13:32 ` [PATCH 3/3] ext4: initialize 'error' variable in ext4_xattr_block_find() Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213232104.GH21641@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.