From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 14 Feb 2012 01:51:09 -0500 Subject: [U-Boot] [PATCH 07/28] net: Move PING out of net.c In-Reply-To: References: <1327020811-1538-1-git-send-email-joe.hershberger@ni.com> <201202030707.40719.vapier@gentoo.org> Message-ID: <201202140151.10397.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 13 February 2012 18:54:46 Joe Hershberger wrote: > On Fri, Feb 3, 2012 at 6:07 AM, Mike Frysinger wrote: > > hmm, thinking a bit more, i wonder if it makes more sense to split all of > > icmp out of net.c > > This would also be fine. Are you thinking that icmp would include all > of icmp or would we still have ping separate? Does this need to be > done now? It would be quite a bit of churn to move ping changes to a > different file first since the changes after the move would have to be > manually recreated. keeping ping.c is fine, but i think we should also have icmp.c broken out of net.c. since we're keeping ping.c, no need to rebase onto a new patch. icmp.c can come after these. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: