From: Greg KH <gregkh@linuxfoundation.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
"Justin P. Mattock" <justinmattock@gmail.com>,
Ilia Mirkin <imirkin@alum.mit.edu>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: Re: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()
Date: Mon, 13 Feb 2012 20:05:46 -0800 [thread overview]
Message-ID: <20120214040546.GA17165@kroah.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1202120051310.7100@swampdragon.chaosbits.net>
On Sun, Feb 12, 2012 at 12:54:31AM +0100, Jesper Juhl wrote:
> On Fri, 10 Feb 2012, Greg KH wrote:
>
> > On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > > From: Jesper Juhl <jj@codesealer.com>
> > >
> > > We allocate memory for 'pstAddIndication' with kmalloc() in
> > > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > > neglect to free it on a number of exit paths from that function.
> > >
> > > This could probably be resolved cleaner/nicer, but this file needs a
> > > serious overhaul in any case, so I opted for just fixing the problem
> > > as directly as I could and then we can clean it up generally
> > > later... This at least makes it stop bleeding..
> > >
> > > Signed-off-by: Jesper Juhl <jj@codesealer.com>
> >
> > Odd, didn't I already apply this patch?
> >
> > confused,
> >
>
> Well, you were the one who (in email message with Message-ID:
> <20120209175217.GA13959@kroah.com>) said that it no longer applied and
> asked for a resubmit against linux-next:
>
> "This patch no longer applies, care to redo it against the latest
> linux-next tree?"
>
> So I just did what you asked :-)
Yes, but...
> Whether or not you have already applied it somewhere else I have no
> idea...
I tried to apply this, and it said it was already applied. So either I
already merged it, or someone else made the same patch, or you created
it reverted.
I'm confused, sorry.
greg k-h
prev parent reply other threads:[~2012-02-14 4:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 22:44 [PATCH 0/2] Staging: Style cleanup and mem leak fixes for drivers/staging/bcm/CmHost.c Jesper Juhl
2012-01-24 22:46 ` [PATCH 1/2] Staging; bcm/CmHost.c: Style cleanup Jesper Juhl
2012-01-24 23:13 ` Joe Perches
2012-01-24 23:17 ` Jesper Juhl
2012-01-25 6:26 ` Dan Carpenter
2012-01-27 23:43 ` Jesper Juhl
2012-01-28 7:24 ` Dan Carpenter
2012-01-24 22:47 ` [PATCH 2/2] Staging; Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage() Jesper Juhl
2012-02-09 17:52 ` Greg KH
2012-02-09 22:33 ` Jesper Juhl
2012-02-10 18:00 ` Staging: bcm: " Greg KH
2012-02-11 23:54 ` Jesper Juhl
2012-02-14 4:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214040546.GA17165@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=imirkin@alum.mit.edu \
--cc=jj@chaosbits.net \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.