From: "Henrik Rydberg" <rydberg@euromail.se>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Dmity Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] bcm5974: Add pointer and buttonpad properties
Date: Tue, 14 Feb 2012 19:52:16 +0100 [thread overview]
Message-ID: <20120214185216.GA28060@polaris.bitmath.org> (raw)
In-Reply-To: <1329233199-7424-1-git-send-email-chase.douglas@canonical.com>
Hi Chase,
On Tue, Feb 14, 2012 at 07:26:39AM -0800, Chase Douglas wrote:
> In order to inform userspace of physical properties of the device.
>
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
> drivers/input/mouse/bcm5974.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 5ec617e..9faa049 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -434,6 +434,9 @@ static void setup_events_to_report(struct input_dev *input_dev,
> __set_bit(BTN_LEFT, input_dev->keybit);
>
> input_set_events_per_packet(input_dev, 60);
> +
> + __set_bit(INPUT_PROP_POINTER, input->propbit);
> + __set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
> }
>
> /* report button data as logical button state */
> --
> 1.7.9
>
Applied, with fixes. The patch did not apply, and once resolved, did
not compile. I trust you will test also the trivial patches in the future.
Thanks.
Henrik
next prev parent reply other threads:[~2012-02-14 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 15:26 [PATCH v2] bcm5974: Add pointer and buttonpad properties Chase Douglas
2012-02-14 18:52 ` Henrik Rydberg [this message]
2012-02-14 19:01 ` Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214185216.GA28060@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.