From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH 06 of 10] xenpaging: improve performance in policy_choose_victim
Date: Tue, 14 Feb 2012 22:08:51 +0100 [thread overview]
Message-ID: <20120214210851.GA21988@aepfle.de> (raw)
In-Reply-To: <b7906ad2815304272686.1327939169@probook.site>
On Mon, Jan 30, Olaf Hering wrote:
> +++ b/tools/xenpaging/policy_default.c
> @@ -80,33 +80,58 @@ int policy_init(struct xenpaging *paging
> unsigned long policy_choose_victim(struct xenpaging *paging)
> +
> + /* gfn busy */
> + if ( test_bit(current_gfn, bitmap) )
> + continue;
> +
> + /* gfn already tested */
> + if ( test_bit(current_gfn, bitmap) )
> + continue;
> +
> + /* gfn found */
> + break;
The second one should be "unconsumed" instead of "bitmap", otherwise
wraparounds lead to endless loop in caller..
Olaf
next prev parent reply other threads:[~2012-02-14 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 15:59 [PATCH 00 of 10] tools/xenpaging: cleanups and performance improvements Olaf Hering
2012-01-30 15:59 ` [PATCH 01 of 10] xenpaging: use flat index for pagefile and page-in requests Olaf Hering
2012-01-30 15:59 ` [PATCH 02 of 10] xenpaging: no poll timeout while page-out is in progress Olaf Hering
2012-01-30 15:59 ` [PATCH 03 of 10] xenpaging: mmap guest pages read-only Olaf Hering
2012-01-30 15:59 ` [PATCH 04 of 10] xenpaging: reduce number of qemu cache flushes Olaf Hering
2012-01-30 15:59 ` [PATCH 05 of 10] xenpaging: move nominate+evict into single function Olaf Hering
2012-01-30 15:59 ` [PATCH 06 of 10] xenpaging: improve performance in policy_choose_victim Olaf Hering
2012-02-14 21:08 ` Olaf Hering [this message]
2012-01-30 15:59 ` [PATCH 07 of 10] xenpaging: unify error handling Olaf Hering
2012-01-30 15:59 ` [PATCH 08 of 10] xenpaging: move pagefile filedescriptor into struct xenpaging Olaf Hering
2012-01-30 15:59 ` [PATCH 09 of 10] xenpaging: move page_buffer " Olaf Hering
2012-01-30 15:59 ` [PATCH 10 of 10] xenpaging: implement stack of free slots in pagefile Olaf Hering
2012-02-09 17:57 ` [PATCH 00 of 10] tools/xenpaging: cleanups and performance improvements Ian Jackson
2012-02-20 17:25 ` [PATCH 06 of 10] xenpaging: improve performance in policy_choose_victim [and 1 more messages] Ian Jackson
2012-02-20 18:48 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214210851.GA21988@aepfle.de \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.