From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH]QNX6 filesystem (RO) driver
Date: Wed, 15 Feb 2012 07:57:50 +0000
Message-ID: <20120215075750.GG23916@ZenIV.linux.org.uk>
References: <4F29A37F.6070909@ontika.net>
 <20120212045629.GO23916@ZenIV.linux.org.uk>
 <4F3839CE.8040805@ontika.net>
 <20120212224358.GW23916@ZenIV.linux.org.uk>
 <4F3B1DD1.3000202@ontika.net>
 <20120215061012.GC23916@ZenIV.linux.org.uk>
 <20120215064728.GE23916@ZenIV.linux.org.uk>
 <20120215071119.GF23916@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Kai Bankett <chaosman@ontika.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:52951 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751235Ab2BOH5w (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 15 Feb 2012 02:57:52 -0500
Content-Disposition: inline
In-Reply-To: <20120215071119.GF23916@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Feb 15, 2012 at 07:11:19AM +0000, Al Viro wrote:

> One more thing - unless I'm misreading the code it looks like your ->sb becomes
> a dangling pointer once fill_super finishes and ->statfs() is dereferencing
> it...

BTW, what happens if root directory grows to more than one level of
pointers?  AFAICS, qnx6_checkroot() assumes that it won't happen...
And why not do that after getting the root inode, anyway?