From: Ted Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: When truncating file, punch out blocks at end
Date: Wed, 15 Feb 2012 15:12:42 -0500 [thread overview]
Message-ID: <20120215201242.GJ11382@thunk.org> (raw)
In-Reply-To: <20120107044737.3366.45151.stgit@elm3c44.beaverton.ibm.com>
On Fri, Jan 06, 2012 at 08:47:37PM -0800, Darrick J. Wong wrote:
> Currently, ext2fs_file_set_size2 punches out data blocks between the
> end of the file and infinity when truncate_block <= old_truncate
> (i.e. when you've made the file longer). This is not a useful
> behavior, particularly since it *fails* to punch out the data blocks
> when the file is shortened (i.e. truncate_block < old_truncate).
> This seems to be the result of the test being backwards, so fix the
> code to punch only when the file is getting shorter.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2012-02-15 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 4:47 [PATCH] libext2fs: When truncating file, punch out blocks at end Darrick J. Wong
2012-02-15 20:12 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215201242.GJ11382@thunk.org \
--to=tytso@mit.edu \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.