From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/9] xfs: use per-CPU data for the quota statistics
Date: Thu, 16 Feb 2012 10:59:29 +1100 [thread overview]
Message-ID: <20120215235929.GP14132@dastard> (raw)
In-Reply-To: <20120215023147.414783335@bombadil.infradead.org>
On Tue, Feb 14, 2012 at 09:29:30PM -0500, Christoph Hellwig wrote:
> Use the same per-CPU scheme used in the main XFS statistics, as well as
> the VFS inode and dcache statistics for the quota code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
.....
> -struct xqmstats xqmstats;
> +DEFINE_PER_CPU(struct xqmstats, xqmstats);
> +
> +static int xqmstats_sum(int idx)
> +{
> + int val = 0, cpu;
> +
> + for_each_possible_cpu(cpu)
> + val += *(((__u32 *)&per_cpu(xqmstats, cpu) + idx));
> + return max(val, 0);
> +}
Why not just make val a 64bit value so overflow is simply not an
issue?
Otherwise, all looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-15 23:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 2:29 [PATCH 0/9] quota updates V2 Christoph Hellwig
2012-02-15 2:29 ` [PATCH 1/9] xfs: use per-filesystem dquot LRU lists Christoph Hellwig
2012-02-15 22:10 ` Dave Chinner
2012-02-17 17:33 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup Christoph Hellwig
2012-02-15 22:21 ` Dave Chinner
2012-02-17 17:38 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 3/9] xfs: remove the per-filesystem list of dquots Christoph Hellwig
2012-02-15 22:59 ` Dave Chinner
2012-02-17 17:47 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 4/9] xfs: use per-CPU data for the quota statistics Christoph Hellwig
2012-02-15 23:59 ` Dave Chinner [this message]
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 5/9] xfs: user per-cpu stats for the total dquot numbers Christoph Hellwig
2012-02-16 0:02 ` Dave Chinner
2012-02-17 17:48 ` Christoph Hellwig
2012-02-15 2:29 ` [PATCH 6/9] xfs: remove the global xfs_Gqm structure Christoph Hellwig
2012-02-16 0:07 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota Christoph Hellwig
2012-02-16 0:11 ` Dave Chinner
2012-02-27 1:57 ` Ben Myers
2012-02-15 2:29 ` [PATCH 8/9] xfs: include reservations in quota reporting Christoph Hellwig
2012-02-16 0:14 ` Dave Chinner
2012-02-15 2:29 ` [PATCH 9/9] quota: make Q_XQUOTASYNC a noop Christoph Hellwig
2012-02-16 0:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215235929.GP14132@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.