From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] qnx4fs: small cleanup #2
Date: Thu, 16 Feb 2012 10:09:33 +0000
Message-ID: <20120216100933.GK23916@ZenIV.linux.org.uk>
References: <4F386ACD.2010908@ontika.net>
 <20120214040030.GY23916@ZenIV.linux.org.uk>
 <4F3C3399.7090407@ontika.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Kai Bankett <chaosman@ontika.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:43652 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751241Ab2BPKJe (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 16 Feb 2012 05:09:34 -0500
Content-Disposition: inline
In-Reply-To: <4F3C3399.7090407@ontika.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Feb 15, 2012 at 11:37:13PM +0100, Kai Bankett wrote:
>  				rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE);
> -				if (rootdir->di_fname != NULL) {
> +				if (!rootdir->di_fname) {

Huh???
	a) this actually inverts the test
	b) ->di_fname is actually an array; the test made no
sense even before that change; it's _never_ NULL.  See commit
1aab323ea5cd67d2d2572a1f2794978583ff8545 in -rc1...