From: Wolfram Sang <w.sang@pengutronix.de>
To: Oskar Schirmer <oskar@scara.com>
Cc: wim@iguana.be, s.hauer@pengutronix.de,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: make imx2_wdt report boot status correctly
Date: Thu, 16 Feb 2012 14:35:10 +0100 [thread overview]
Message-ID: <20120216133510.GA2541@pengutronix.de> (raw)
In-Reply-To: <1329394665-7238-1-git-send-email-oskar@scara.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Hi Oskar,
besides this minor thing (which may be just personal taste)...
> + case WDIOC_GETBOOTSTATUS:
> + val = __raw_readw(imx2_wdt.base + IMX2_WDT_WRSR);
> + new_value = 0;
> + if (val & IMX2_WDT_WRSR_TOUT)
> + new_value = WDIOF_CARDRESET;
I'd go for this to save some lines:
new_value = val & IMX2_WDT_WRSR_TOUT ? WDIOF_CARDRESET : 0;
But in general:
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-16 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 12:17 [PATCH] watchdog: make imx2_wdt report boot status correctly Oskar Schirmer
2012-02-16 13:35 ` Wolfram Sang [this message]
2012-02-16 14:17 ` Oskar Schirmer
2012-02-16 14:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216133510.GA2541@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=oskar@scara.com \
--cc=s.hauer@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.