From: Jim Rees <rees@umich.edu>
To: Weston Andros Adamson <dros@netapp.com>
Cc: trond.myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] NFSv4: Send implementation id with exchange_id
Date: Thu, 16 Feb 2012 12:30:22 -0500 [thread overview]
Message-ID: <20120216173022.GA29158@umich.edu> (raw)
In-Reply-To: <1329409026-20466-1-git-send-email-dros@netapp.com>
Weston Andros Adamson wrote:
Send the nfs implementation id in EXCHANGE_ID requests unless the module
parameter nfs.send_implementation_id is 0.
This adds a CONFIG variable for the nii_domain that defaults to "kernel.org".
Signed-off-by: Weston Andros Adamson <dros@netapp.com>
@@ -271,7 +273,12 @@ static int nfs4_stat_to_errno(int);
1 /* flags */ + \
1 /* spa_how */ + \
0 /* SP4_NONE (for now) */ + \
- 1 /* zero implemetation id array */)
+ 1 /* implemetation id array of size 1 */ + \
implemetation -> implementation
Might as well fix this typo while you're at it.
General comment... If this is going to be configurable, I'd rather make it a
sysctl, and be able to set the id to whatever I want at run time. But
that's because I like to be able to break things. I suspect Trond will
disagree.
next prev parent reply other threads:[~2012-02-16 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 16:17 [PATCH 1/3] NFSv4: Send implementation id with exchange_id Weston Andros Adamson
2012-02-16 16:17 ` [PATCH 2/3] NFSv4: fix server_scope memory leak Weston Andros Adamson
2012-02-16 20:43 ` Myklebust, Trond
2012-02-16 20:44 ` Adamson, Dros
2012-02-16 16:17 ` [PATCH 3/3] NFSv4: parse and display server implementation ids Weston Andros Adamson
2012-02-16 17:30 ` Jim Rees [this message]
2012-02-16 17:36 ` [PATCH 1/3] NFSv4: Send implementation id with exchange_id Myklebust, Trond
2012-02-16 17:37 ` Adamson, Dros
2012-02-16 17:41 ` Adamson, Dros
2012-02-16 20:10 ` Jim Rees
2012-02-16 20:35 ` Myklebust, Trond
2012-02-16 20:40 ` Myklebust, Trond
2012-02-16 20:52 ` Adamson, Dros
-- strict thread matches above, loose matches on Subject: below --
2012-02-17 20:20 Weston Andros Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216173022.GA29158@umich.edu \
--to=rees@umich.edu \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.