From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Emelyanov <xemul@parallels.com>,
Andrey Vagin <avagin@openvz.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Glauber Costa <glommer@parallels.com>,
Andi Kleen <andi@firstfloor.org>, Tejun Heo <tj@kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Valdis.Kletnieks@vt.edu, Michal Marek <mmarek@suse.cz>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: + syscalls-x86-add-__nr_kcmp-syscall-v8.patch added to -mm tree
Date: Thu, 16 Feb 2012 21:58:09 +0400 [thread overview]
Message-ID: <20120216175809.GJ1905@moon> (raw)
In-Reply-To: <20120216174047.GA31176@redhat.com>
On Thu, Feb 16, 2012 at 06:40:47PM +0100, Oleg Nesterov wrote:
> On 02/16, Cyrill Gorcunov wrote:
> >
> > -static void access_unlock(struct task_struct *task)
> > +static void kcmp_unlock(struct mutex *m1, struct mutex *m2)
> > {
> > - mutex_unlock(&task->signal->cred_guard_mutex);
> > + if (m2 > m1)
> > + swap(m1, m2);
>
> Well, the order doesn't matter in case of _unlock, you can remove
> this part. Not that it really hurts though, I won't argue.
>
It drops some instructions so I think it worth removing (still
unlocking not in reverse order is something which always make
me nervious ;)
Cyrill
next prev parent reply other threads:[~2012-02-16 17:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 14:36 + syscalls-x86-add-__nr_kcmp-syscall-v8.patch added to -mm tree Oleg Nesterov
2012-02-15 15:10 ` Cyrill Gorcunov
2012-02-15 15:38 ` Oleg Nesterov
2012-02-15 16:13 ` Cyrill Gorcunov
2012-02-15 16:22 ` Oleg Nesterov
2012-02-15 17:53 ` Cyrill Gorcunov
2012-02-15 18:43 ` Oleg Nesterov
2012-02-15 19:56 ` Cyrill Gorcunov
2012-02-15 19:57 ` Vasiliy Kulikov
2012-02-15 20:05 ` Cyrill Gorcunov
2012-02-15 20:25 ` Cyrill Gorcunov
2012-02-15 21:09 ` Cyrill Gorcunov
2012-02-15 21:58 ` Cyrill Gorcunov
2012-02-16 14:49 ` Oleg Nesterov
2012-02-16 15:13 ` Cyrill Gorcunov
2012-02-16 16:49 ` Cyrill Gorcunov
2012-02-16 17:40 ` Oleg Nesterov
2012-02-16 17:58 ` Cyrill Gorcunov [this message]
2012-02-16 19:03 ` Oleg Nesterov
2012-02-16 19:20 ` H. Peter Anvin
2012-02-16 19:29 ` Cyrill Gorcunov
2012-02-16 19:52 ` Andrew Morton
2012-02-16 20:01 ` Cyrill Gorcunov
2012-02-16 18:21 ` Vasiliy Kulikov
2012-02-16 18:34 ` Cyrill Gorcunov
2012-02-16 18:33 ` Vasiliy Kulikov
2012-02-16 18:49 ` Oleg Nesterov
2012-02-15 18:32 ` Cyrill Gorcunov
2012-02-15 19:06 ` Oleg Nesterov
2012-02-15 19:18 ` Cyrill Gorcunov
2012-02-15 16:06 ` Oleg Nesterov
2012-02-15 16:27 ` Cyrill Gorcunov
2012-04-09 22:10 ` Andrew Morton
2012-04-09 22:24 ` Cyrill Gorcunov
2012-04-09 23:22 ` H. Peter Anvin
2012-04-10 22:37 ` Cyrill Gorcunov
2012-04-10 22:39 ` H. Peter Anvin
2012-04-10 22:48 ` Cyrill Gorcunov
2012-04-10 23:08 ` Oleg Nesterov
2012-04-10 23:32 ` H. Peter Anvin
2012-04-10 23:42 ` Oleg Nesterov
2012-04-11 6:39 ` Cyrill Gorcunov
2012-04-11 18:31 ` Oleg Nesterov
2012-04-11 0:02 ` Valdis.Kletnieks
2012-04-10 3:25 ` Eric W. Biederman
2012-04-10 22:54 ` Cyrill Gorcunov
2012-04-10 23:58 ` Valdis.Kletnieks
2012-04-11 0:06 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2012-02-14 23:15 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216175809.GJ1905@moon \
--to=gorcunov@openvz.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=glommer@parallels.com \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=mmarek@suse.cz \
--cc=oleg@redhat.com \
--cc=penberg@kernel.org \
--cc=segoon@openwall.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.