From: Gert Doering <gert@...1296...>
To: Heiko Hund <heiko.hund@...1489...>
Cc: openvpn-devel@lists.sourceforge.net
Subject: Re: [Openvpn-devel] [PATCH 3/4] use the underscore version of stat on Windows
Date: Thu, 16 Feb 2012 19:29:09 +0100 [thread overview]
Message-ID: <20120216182908.GM7024@...1296...> (raw)
In-Reply-To: <1329413441-22538-4-git-send-email-heiko.hund@...1489...>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hi,
On Thu, Feb 16, 2012 at 06:30:40PM +0100, Heiko Hund wrote:
> MSVC does not know wstat(). Instead _wstat() must be used here.
> Unfortunately _wstat() takes a 'struct _stat'. A type 'stat_t' is
> introduced to handle this situation in a portable way.
Semi-ACK.
In general, ACK, though it might be a bit easier to understand the code
if there were an explantory comment at the typedef, and the type would be
called "openvpn_stat_t" or such - so that when referenced in pf.c, it's
clear that this is not something "from the build environment" but "local".
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany gert@...1296...
fax: +49-89-35655025 gert@...1297...
[-- Attachment #2: Type: application/pgp-signature, Size: 305 bytes --]
next prev parent reply other threads:[~2012-02-16 18:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 17:30 [Openvpn-devel] MSVC fixes Heiko Hund
2012-02-16 17:30 ` [Openvpn-devel] [PATCH 1/4] replace check for TARGET_WIN32 with WIN32 Heiko Hund
2012-02-16 18:23 ` Gert Doering
2012-02-16 17:30 ` [Openvpn-devel] [PATCH 2/4] do not use mode_t on Windows Heiko Hund
2012-02-16 18:26 ` Gert Doering
2012-02-16 18:34 ` Alon Bar-Lev
2012-02-17 9:39 ` Heiko Hund
2012-02-17 9:56 ` Alon Bar-Lev
2012-02-16 17:30 ` [Openvpn-devel] [PATCH 3/4] use the underscore version of stat " Heiko Hund
2012-02-16 18:29 ` Gert Doering [this message]
2012-02-16 18:47 ` [Openvpn-devel] [PATCH v2] " David Sommerseth
2012-02-16 18:51 ` Gert Doering
2012-02-16 18:53 ` Alon Bar-Lev
2012-02-16 17:30 ` [Openvpn-devel] [PATCH 4/4] make MSVC link against shell32 as well Heiko Hund
2012-02-16 17:47 ` Gert Doering
2012-02-16 18:37 ` Alon Bar-Lev
2012-02-17 9:51 ` Heiko Hund
2012-02-17 9:55 ` Alon Bar-Lev
2012-03-24 20:31 ` [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest Alon Bar-Lev
2012-04-02 11:39 ` Alon Bar-Lev
2012-04-27 8:54 `
2012-04-27 8:59 ` Alon Bar-Lev
2012-04-27 11:13 `
2012-04-27 11:24 ` Alon Bar-Lev
2012-04-27 9:18 ` Heiko Hund
2012-04-27 11:15 `
2012-04-27 11:55 `
2012-04-27 11:59 `
2012-04-27 12:15 ` Alon Bar-Lev
2012-05-02 9:18 ` Alon Bar-Lev
2012-05-03 7:26 ` David Sommerseth
2012-05-03 7:41 ` Alon Bar-Lev
2012-05-03 10:53 `
2012-05-03 17:47 ` Alon Bar-Lev
2012-06-26 10:20 ` Alon Bar-Lev
2012-06-29 8:11 ` David Sommerseth
2012-02-17 10:14 ` [Openvpn-devel] MSVC fixes David Sommerseth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216182908.GM7024@...1296... \
--to=openvpn-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.