From: Alessandro Rubini <rubini@gnudd.com>
To: linus.walleij@linaro.org
Cc: linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
alan@linux.intel.com, sameo@linux.intel.com,
grant.likely@secretlab.ca
Subject: Re: [PATCH V2 2/2] gpio: add STA2X11 GPIO block
Date: Thu, 16 Feb 2012 21:24:20 +0100 [thread overview]
Message-ID: <20120216202420.GA28862@mail.gnudd.com> (raw)
In-Reply-To: <CACRpkdY-U8FgYFkVcbQg57XF7BhsjBcJDopPTLhgRMRLHv7LZA@mail.gmail.com>
Thank Linus for this and the others.
> [Nitpick: spelling]
ack
>> + gpio->base = gpio_base;
>> + gpio->base = 0;
>
> What are you doing here?
An error. Sorry. the latter line must be removed. I'll resend.
> The GPIO pin number space is global and you need to be able to
> handle the case where several controllers of this kind are plugged
> in, will you not?
Yes, I'm pretty careful about this, and it's one of the concerns I
have with the code I got. Unfortunately I only have 1 card plugged in
a PC (and one standalone system where the sta2x11 is the main chipset
and no more chan be plugged). Here I simply made a mistake.
> Make sure that the global GPIO numberspace is properly
> handled on these systems, alas I am a bit worried that this
> may not be that very easy.
No, it was not. But, despite tha extra line from earlier code, it should
work properly with this code layout.
/alessandro
next prev parent reply other threads:[~2012-02-16 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:00 [PATCH V2 0/2] MFD and GPIO for STA2X11 Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block Alessandro Rubini
2012-02-16 19:29 ` Linus Walleij
2012-02-23 16:19 ` Samuel Ortiz
2012-02-23 16:25 ` Alessandro Rubini
2012-02-16 13:00 ` [PATCH V2 2/2] gpio: add STA2X11 GPIO block Alessandro Rubini
2012-02-16 19:16 ` Linus Walleij
2012-02-16 20:24 ` Alessandro Rubini
2012-03-01 18:50 ` Alessandro Rubini
2012-03-01 20:20 ` Linus Walleij
2012-02-16 19:24 ` Linus Walleij
2012-02-16 20:24 ` Alessandro Rubini [this message]
2012-03-02 7:48 ` Grant Likely
2012-03-02 10:00 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216202420.GA28862@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.