From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <elder@dreamhost.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: only take the ILOCK in xfs_reclaim_inode()
Date: Fri, 17 Feb 2012 13:45:21 +1100 [thread overview]
Message-ID: <20120217024521.GG14132@dastard> (raw)
In-Reply-To: <1329429660.16207.19.camel@doink>
On Thu, Feb 16, 2012 at 04:01:00PM -0600, Alex Elder wrote:
> At the end of xfs_reclaim_inode(), the inode is locked in order to
> we wait for a possible concurrent lookup to complete before the
> inode is freed. This synchronization step was taking both the ILOCK
> and the IOLOCK, but the latter was causing lockdep to produce
> reports of the possibility of deadlock.
>
> It turns out that there's no need to acquire the IOLOCK at this
> point anyway. It may have been required in some earlier version of
> the code, but there should be no need to take the IOLOCK in
> xfs_iget(), so there's no (longer) any need to get it here for
> synchronization. Add an assertion in xfs_iget() as a reminder
> of this assumption.
>
> Dave Chinner diagnosed this on IRC, and Christoph Hellwig suggested
> no longer including the IOLOCK. I just put together the patch.
>
> Signed-off-by: Alex Elder <elder@dreamhost.com>
The code and comments is almost identical to the patch I've been
testing over the past day, so consider it
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-17 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 22:01 [PATCH] xfs: only take the ILOCK in xfs_reclaim_inode() Alex Elder
2012-02-17 2:45 ` Dave Chinner [this message]
2012-02-17 19:13 ` Christoph Hellwig
2012-02-25 19:50 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217024521.GG14132@dastard \
--to=david@fromorbit.com \
--cc=elder@dreamhost.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.