From: Dan Carpenter <dan.carpenter@oracle.com>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org
Subject: re: tg3: Use *_UNKNOWN ethtool definitions
Date: Fri, 17 Feb 2012 09:48:30 +0300 [thread overview]
Message-ID: <20120217064830.GA14483@mwanda> (raw)
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Hello Matt Carlson,
The patch e740522e6d3a: "tg3: Use *_UNKNOWN ethtool definitions" from
Feb 13, 2012, leads to the following Smatch warning:
drivers/net/ethernet/broadcom/tg3.c:1822 tg3_adjust_link()
error: tp->link_config.active_speed is never equal to -1 (wrong type 0 - 65535).
- if ((phydev->link && tp->link_config.active_speed == SPEED_INVALID) ||
- (!phydev->link && tp->link_config.active_speed != SPEED_INVALID) ||
+ if ((phydev->link && tp->link_config.active_speed == SPEED_UNKNOWN) ||
+ (!phydev->link && tp->link_config.active_speed != SPEED_UNKNOWN) ||
Since tp->link_config.active_speed is an unsigned short, it never is
equal to SPEED_UNKNOWN (-1).
I introduced the SPEED_UNKNOWN so I feel bad that it's causing trouble
now. :/
Also this warning:
drivers/net/ethernet/broadcom/tg3.c:3909 tg3_phy_copper_begin(14)
error: tp->link_config.speed is never equal to -1 (wrong type 0 - 65535).
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-02-17 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 6:48 Dan Carpenter [this message]
2012-02-18 0:54 ` tg3: Use *_UNKNOWN ethtool definitions Matt Carlson
2012-02-18 1:03 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217064830.GA14483@mwanda \
--to=dan.carpenter@oracle.com \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.