From: Mike Frysinger <vapier@gentoo.org>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Sonic Zhang <sonic.zhang@analog.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Bob Liu <bob.liu@analog.com>,
uclinux-dist-devel@blackfin.uclinux.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin
Date: Fri, 17 Feb 2012 18:15:57 -0500 [thread overview]
Message-ID: <201202171815.59846.vapier@gentoo.org> (raw)
In-Reply-To: <201202171157.55585.danny.kukawka@bisect.de>
[-- Attachment #1: Type: Text/Plain, Size: 818 bytes --]
On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:
> On Freitag, 17. Februar 2012, Mike Frysinger wrote:
> > On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
> > > + netdev_warn(ndev, "Setting Ethernet MAC to a
> > > random one\n"); + eth_hw_addr_random(ndev);
> >
> > would it make sense to have the core dump the warning ?
>
> Maybe. Many drivers already print information about setting a random mac
> address to a netdevice. Some with printk, some via
> netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
> methods. I could unify this, in a next step with a netdev_info in
> eth_hw_addr_random(), if it's okay for David.
i think unification in the core makes sense. it enforces consistency and
removes duplication.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-17 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 17:09 [PATCH v2 0/2] Part 3: handle random addresses on blackfin Danny Kukawka
2012-02-16 17:09 ` [PATCH v2 1/2] arch/blackfin: don't generate random mac in bfin_get_ether_addr() Danny Kukawka
2012-02-17 4:38 ` Mike Frysinger
2012-02-20 0:05 ` David Miller
2012-02-16 17:09 ` [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin Danny Kukawka
2012-02-17 4:37 ` Mike Frysinger
2012-02-17 10:57 ` Danny Kukawka
2012-02-17 23:15 ` Mike Frysinger [this message]
2012-02-17 23:27 ` Joe Perches
2012-02-18 13:28 ` Danny Kukawka
2012-02-19 2:47 ` Mike Frysinger
2012-02-20 0:05 ` David Miller
2012-02-20 0:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202171815.59846.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=bob.liu@analog.com \
--cc=danny.kukawka@bisect.de \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.