From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyTHp-0006n3-HF for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:16:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyTHo-0005WY-1i for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:16:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyTHn-0005WM-Lo for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:16:04 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HJG24B015647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 14:16:02 -0500 Date: Fri, 17 Feb 2012 21:15:57 +0200 From: Alon Levy Message-ID: <20120217191557.GA23926@garlic.redhat.com> References: <1329414355-26909-1-git-send-email-alevy@redhat.com> <4F3E6E3F.4070300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3E6E3F.4070300@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Fri, Feb 17, 2012 at 04:11:59PM +0100, Gerd Hoffmann wrote: > Hi, > > > - if (qxl->vram_size < 16 * 1024 * 1024) { > > + /* a request of 0 vram_size is translated to the smallest vram that doesn't > > + * break current off screen surfaces using drivers */ > > + if (qxl->vram_size > 0 && qxl->vram_size < 16 * 1024 * 1024) { > > Is there any reason to keep the 16MB minimum size? I think we can just > drop it and simplify the logic here. See the patch series just sent. I agree. Will review your patchset. > > cheers, > Gerd >