From: Tejun Heo <tj@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Jens Axboe <axboe@kernel.dk>,
Steve French <sfrench@samba.org>, Chris Ball <cjb@laptop.org>,
Jeff Layton <jlayton@poochiereds.net>,
David Airlie <airlied@linux.ie>,
David Howells <dhowells@redhat.com>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
linux-cifs@vger.kernel.org, linux-mmc@vger.kernel.org,
dri-devel@lists.freedesktop.org, keyrings@linux-nfs.org
Subject: Re: [PATCH] Block: use a freezable workqueue for disk-event polling
Date: Fri, 17 Feb 2012 13:52:04 -0800 [thread overview]
Message-ID: <20120217215204.GH29414@google.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1202171615550.1194-100000@iolanthe.rowland.org>
On Fri, Feb 17, 2012 at 04:22:13PM -0500, Alan Stern wrote:
> This patch (as1519) fixes a bug in the block layer's disk-events
> polling. The polling is done by a work routine queued on the
> system_nrt_wq workqueue. Since that workqueue isn't freezable, the
> polling continues even in the middle of a system sleep transition.
>
> Obviously, polling a suspended drive for media changes and such isn't
> a good thing to do; in the case of USB mass-storage devices it can
> lead to real problems requiring device resets and even re-enumeration.
>
> The patch fixes things by creating a new system-wide, non-reentrant,
> freezable workqueue and using it for disk-events polling.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Tejun Heo <tj@kernel.org>
> CC: <stable@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
--
tejun
next prev parent reply other threads:[~2012-02-17 21:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 14:41 system_nrt_wq, system suspend, and the freezer Alan Stern
2012-02-16 14:41 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1202160930010.1268-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-02-16 15:22 ` David Howells
[not found] ` <32626.1329405744-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-02-16 16:26 ` Tejun Heo
[not found] ` <20120216162634.GE24986-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-02-16 16:35 ` David Howells
2012-02-16 16:37 ` Tejun Heo
2012-02-16 15:27 ` Jeff Layton
2012-02-16 15:27 ` Jeff Layton
[not found] ` <20120216102728.230b99ba-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
2012-02-16 16:29 ` Tejun Heo
[not found] ` <20120216162951.GF24986-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-02-16 16:42 ` Alan Stern
2012-02-16 16:42 ` Alan Stern
2012-02-16 18:59 ` Jeff Layton
[not found] ` <20120216135945.3dd3893a-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2012-02-16 19:01 ` Tejun Heo
2012-02-17 21:22 ` [PATCH] Block: use a freezable workqueue for disk-event polling Alan Stern
2012-02-17 21:22 ` Alan Stern
2012-02-17 21:52 ` Tejun Heo [this message]
2012-02-17 22:11 ` Rafael J. Wysocki
2012-03-02 9:51 ` Jens Axboe
2012-02-16 16:25 ` system_nrt_wq, system suspend, and the freezer Tejun Heo
[not found] ` <20120216162529.GD24986-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-02-16 16:37 ` Alan Stern
2012-02-16 16:37 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1202161131420.1268-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-02-16 16:45 ` Tejun Heo
2012-02-16 16:58 ` Alan Stern
2012-02-16 16:58 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217215204.GH29414@google.com \
--to=tj@kernel.org \
--cc=airlied@linux.ie \
--cc=axboe@kernel.dk \
--cc=cjb@laptop.org \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jlayton@poochiereds.net \
--cc=keyrings@linux-nfs.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sfrench@samba.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.