From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: "Paul E. McKenney" <paul.mckenney@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] rcu: stop spurious warnings from synchronize_sched_expedited
Date: Fri, 17 Feb 2012 14:10:05 -0800 [thread overview]
Message-ID: <20120217221005.GX2976@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1202171318010.5994@eggly.anvils>
On Fri, Feb 17, 2012 at 01:20:31PM -0800, Hugh Dickins wrote:
> synchronize_sched_expedited() is spamming CONFIG_DEBUG_PREEMPT=y
> users with an unintended warning from the cpu_is_offline() check:
> use raw_smp_processor_id() instead of smp_processor_id() there.
Good catch! Queued.
Thanx, Paul
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>
> kernel/rcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- next/kernel/rcutree.c 2012-02-17 08:02:15.680065066 -0800
> +++ linux/kernel/rcutree.c 2012-02-17 10:41:18.764003566 -0800
> @@ -2014,7 +2014,7 @@ void synchronize_sched_expedited(void)
> /* Note that atomic_inc_return() implies full memory barrier. */
> firstsnap = snap = atomic_inc_return(&sync_sched_expedited_started);
> get_online_cpus();
> - WARN_ON_ONCE(cpu_is_offline(smp_processor_id()));
> + WARN_ON_ONCE(cpu_is_offline(raw_smp_processor_id()));
>
> /*
> * Each pass through the following loop attempts to force a
>
prev parent reply other threads:[~2012-02-17 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 21:20 [PATCH next] rcu: stop spurious warnings from synchronize_sched_expedited Hugh Dickins
2012-02-17 22:10 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217221005.GX2976@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.mckenney@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.