All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] firewire: net: identify to driver core as "firewire_net", not "net"
Date: Sat, 18 Feb 2012 22:01:54 +0100	[thread overview]
Message-ID: <20120218220154.44a39bf2@stein> (raw)
In-Reply-To: <20120218215824.5b2359bf@stein>

On second thought, there is little reason to have driver name differ
from module name.  Therefore, change
    /sys/bus/firewire/drivers/net
    /sys/bus/firewire/devices/fw0.0/driver -> [...]/net
    /sys/module/firewire_net/drivers/firewire:net
to
    /sys/bus/firewire/drivers/firewire_net
    /sys/bus/firewire/devices/fw0.0/driver -> [...]/firewire_net
    /sys/module/firewire_net/drivers/firewire:firewire_net
It is redundant but consistent with firewire-sbp2's recently changed
driver name.

I don't see this anywhere used, so it should not matter either way.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1648,7 +1648,7 @@ static const struct ieee1394_device_id f
 static struct fw_driver fwnet_driver = {
 	.driver = {
 		.owner  = THIS_MODULE,
-		.name   = "net",
+		.name   = KBUILD_MODNAME,
 		.bus    = &fw_bus_type,
 		.probe  = fwnet_probe,
 		.remove = fwnet_remove,


-- 
Stefan Richter
-=====-===-- --=- =--=-
http://arcgraph.de/sr/

  parent reply	other threads:[~2012-02-18 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 20:58 [PATCH 0/4] firewire, some more logging related patches Stefan Richter
2012-02-18 21:01 ` [PATCH 1/4] firewire: sbp2: identify to driver core as "firewire_sbp2", not "sbp2" Stefan Richter
2012-02-18 21:01 ` Stefan Richter [this message]
2012-02-18 21:02 ` [PATCH 3/4] firewire: net: prefix all log messages with interface name Stefan Richter
2012-02-18 21:32   ` Joe Perches
2012-02-19 11:48     ` Stefan Richter
2012-02-18 21:03 ` [PATCH 4/4] firewire: core: prefix log messages with card name Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120218220154.44a39bf2@stein \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.