From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzSVm-0001hG-R9 for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:38:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzSVh-0004RM-4h for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:38:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzSVg-0004RG-UY for qemu-devel@nongnu.org; Mon, 20 Feb 2012 07:38:29 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1KCcSB9005652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Feb 2012 07:38:28 -0500 Date: Mon, 20 Feb 2012 14:38:23 +0200 From: Alon Levy Message-ID: <20120220123823.GG23926@garlic.redhat.com> References: <1329686886-6853-1-git-send-email-alevy@redhat.com> <1329686886-6853-8-git-send-email-alevy@redhat.com> <4F423155.1010706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F423155.1010706@redhat.com> Subject: Re: [Qemu-devel] [RFC 7/7] qxl: add allocator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, elmarco@redhat.com On Mon, Feb 20, 2012 at 12:41:09PM +0100, Gerd Hoffmann wrote: > On 02/19/12 22:28, Alon Levy wrote: > > Add an implementation of the DisplayAllocator callbacks for qxl. Uses > > the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 > > bits per pixel line convertion. Since free/resize/create are defined in > > qxl.c, it is easy to ensure consistent usage of the flag (it means > > QXL_ALLOCATED basically). > > > > With this patch and the previous two screendump works for vga and qxl > > modes when using qxl and spice together. This might break sdl/vnc with > > spice, untested since it isn't of known use. > > Breaking vnc+spice being used in parallel breaking is exactly what I > suspect might be possible. IIRC there where discussions about just > enabling both vnc+spice, then let users pick what to use, so I'd prefer > to not break this. I'll send a series that works with vnc+spice and sdl+spice (didn't test sdl+vnc+spice), and screendumps at the same time. > > Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. So you think I should introduce a new flag? I could introduce a QEMU_DISPLAYSURFACE_MAX and then use QEMU_DISPLAY_SURFACE_MAX<<1 for my own flag. Actually I think the right thing is to move/copy the 24bit->32bit convertion from vga.c to pflib.c, what do you think? > > cheers, > Gerd >