From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: Add __devinit and __devexit annotations in wm8994
Date: Mon, 20 Feb 2012 18:03:06 +0100 [thread overview]
Message-ID: <20120220170306.GF5387@sortiz-mobl> (raw)
In-Reply-To: <1327327172-8411-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Mon, Jan 23, 2012 at 01:59:30PM +0000, Mark Brown wrote:
> The wm8994_device_init() and wm8994_device_exit() functions were not
> annotated as device init and exit functions, meaning they shouldn't
> reference __devinitdata.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> This is mostly just a warning fix for the second patch and doesn't seem
> terribly critical otherwise so it should probably get merged along with
> it.
Fine with me as well.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-02-20 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 13:59 [PATCH 1/3] mfd: Add __devinit and __devexit annotations in wm8994 Mark Brown
2012-01-23 13:59 ` [PATCH 2/3] mfd/ASoC: Convert WM8994 driver to use regmap patches Mark Brown
2012-02-20 17:02 ` Samuel Ortiz
2012-01-23 13:59 ` [PATCH 3/3] ASoC: Convert the WM5100 revision A updates to a regmap patch Mark Brown
2012-02-20 17:03 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220170306.GF5387@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.