From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/17] OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon.
Date: Mon, 20 Feb 2012 10:36:44 -0700 [thread overview]
Message-ID: <20120220173644.GA20889@bill-the-cat> (raw)
In-Reply-To: <1329480333-18353-5-git-send-email-r.sricharan@ti.com>
On Fri, Feb 17, 2012 at 05:35:20PM +0530, R Sricharan wrote:
> The OMAP5 silicon has new DDR PHY design, which includes a external PHY
> as well. So configuring the ext PHY parameters here. Also the EMIF timimg
> registers and a couple of DDR mode registers needs to be updated based on
> the testing from the actual silicon.
[snip]
> + /* external phy 6-24 registers do not change with
> + * ddr frequency
Here and elsewhere, incorrectly styled comments.
[snip]
> /* Maximum delay before Low Power Modes */
> +#ifndef CONFIG_OMAP54XX
> #define REG_CS_TIM 0xF
> +#else
> +#define REG_CS_TIM 0x0
> +#endif
You used spaces not tabs and I think checkpatch will note that for you
as well (so I expect v2 of the series to be checkpatch clean, aside from
80char wide stuff in those tables).
--
Tom
next prev parent reply other threads:[~2012-02-20 17:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 12:05 [U-Boot] [PATCH 00/17] OMAP5: Add the Changes required for OMAP5 ES1.0 silicon R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 01/17] OMAP5: clocks: Change clock settings as required for " R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 02/17] OMAP5: board: Add pinmux data for omap5_evm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 03/17] omap5: io: Configure the io settings for omap5430 sevm board R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 04/17] OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon R Sricharan
2012-02-20 17:36 ` Tom Rini [this message]
2012-02-21 7:53 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 05/17] OMAP5: palmas: Configure nominal opp vdd values R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 06/17] OMAP5: hwinit: Add the missing break statement R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 07/17] OMAP4/5: Make the silicon revision variable common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 08/17] OMAP5: SRAM: Change the SRAM base address R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 09/17] OMAP4/5: Make the sysctrl structure common R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 10/17] OMAP4/5: device: Add support to get the device type R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 11/17] OMAP5: defconfig: Align the defconfig for 5430 ES1.0 R Sricharan
2012-02-20 17:45 ` Tom Rini
2012-02-21 7:46 ` R, Sricharan
2012-02-21 14:49 ` Tom Rini
2012-02-21 15:20 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 12/17] OMAP5: ddr: Change the ddr device name R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 13/17] OMAP4/5: emif: Correct the emif power mgt shadow register bit fields R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 14/17] arm: omap5: correct boot device mode7 for eMMC R Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 15/17] power: twl6035: add palmas PMIC support R Sricharan
2012-02-20 17:49 ` Tom Rini
2012-02-21 10:58 ` R, Sricharan
2012-02-17 12:05 ` [U-Boot] [PATCH 16/17] omap5: pbias ldo9 turn on R Sricharan
2012-02-20 17:52 ` Tom Rini
2012-02-17 12:05 ` [U-Boot] [PATCH 17/17] mmc: omap5evm: Add eMMC saveenv support R Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220173644.GA20889@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.