From: Dan Carpenter <dan.carpenter@oracle.com>
To: pradheep.sh@gmail.com
Cc: gregkh@linuxfoundation.org, lucas.demarchi@profusion.mobi,
devel@driverdev.osuosl.org, devel@linuxdriverproject.org,
Andy Whitcroft <apw@canonical.com>,
joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings in Version.h
Date: Mon, 20 Feb 2012 21:31:09 +0300 [thread overview]
Message-ID: <20120220183109.GL2855@mwanda> (raw)
In-Reply-To: <4f428dfc.e302440a.02ba.6747@mx.google.com>
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On Mon, Feb 20, 2012 at 10:15:54AM -0800, pradheep.sh@gmail.com wrote:
> -#define VER_FILEVERSION 5.2.45
> -#define VER_FILEVERSION_STR "5.2.45"
> +#define VER_FILEVERSION (5.2.45)
> +#define VER_FILEVERSION_STR ("5.2.45")
These don't need parenthesis. It's bug checkpatch.pl that says that
they do.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next parent reply other threads:[~2012-02-20 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4f428dfc.e302440a.02ba.6747@mx.google.com>
2012-02-20 18:31 ` Dan Carpenter [this message]
[not found] ` <CANz8tm3t5HM9QeNk+h4gNtbTs2UUW1qOe0t=TgnuSD3_gw_A7Q@mail.gmail.com>
2012-02-20 19:09 ` [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings in Version.h Dan Carpenter
[not found] ` <CANz8tm16FvLjUbgPWTsiz5WTje-bRCEAE1eWx3=F48Lm66-Tyg@mail.gmail.com>
2012-02-22 11:21 ` Andy Whitcroft
2012-02-22 13:51 ` Macros with complex values should be enclosed in parenthesis Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220183109.GL2855@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=pradheep.sh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.