From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Patrick McHardy <kaber@trash.net>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
netdev@vger.kernel.org, davem@davemloft.net,
netfilter-devel@vger.kernel.org
Subject: Re: [RFT] nf_contrack_udp: handle packets with padding and hwchecksum
Date: Tue, 21 Feb 2012 13:19:11 +0100 [thread overview]
Message-ID: <20120221121911.GA25258@1984> (raw)
In-Reply-To: <20120217101648.01f31fcd@nehalam.linuxnetplumber.net>
Hi Stephen,
On Fri, Feb 17, 2012 at 10:16:48AM -0800, Stephen Hemminger wrote:
> If UDP packet with extra padding is received on a device that
> does hardware checksumming (but not checking) is processed
> by netfilter conntrack, it would generate a bogus warning
> about the checksum being incorrect.
>
> There were two possible solutions. The netfilter conntrack
> code could trim the packet, discarding the extra padding
> and adjusting the checksum. Or it can force regular
> non-offloaded checksum. This patch implements the latter
> on the principal that is better for firewall code to not
> modify the packet.
I like this approach.
> Compile tested only; haven't been able to reproduce the
> problem yet.
Let me know if I should pass this to davem once you confirm this fixes
the problem you're noticing.
next prev parent reply other threads:[~2012-02-21 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 15:58 Regression in skge that started around acb42a3 (so past v3.3-rc1) Konrad Rzeszutek Wilk
2012-01-30 16:38 ` Stephen Hemminger
2012-01-30 17:22 ` Eric Dumazet
2012-02-17 18:16 ` [RFT] nf_contrack_udp: handle packets with padding and hwchecksum Stephen Hemminger
2012-02-21 12:19 ` Pablo Neira Ayuso [this message]
2012-01-30 17:57 ` Regression in skge that started around acb42a3 (so past v3.3-rc1) Konrad Rzeszutek Wilk
2012-01-30 18:02 ` David Miller
2012-01-30 18:22 ` Konrad Rzeszutek Wilk
2012-02-17 14:10 ` Konrad Rzeszutek Wilk
2012-02-17 15:45 ` Stephen Hemminger
2012-02-17 15:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221121911.GA25258@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.