From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1 of 4 v3] blkif.h: Miscelaneous style fixes
Date: Tue, 21 Feb 2012 09:10:52 -0500
Message-ID: <20120221141052.GD11950@phenom.dumpdata.com>
References: <patchbomb.1329761241@ns1.eng.sldomain.com>
	<28137a4e39a3ed61511f.1329761242@ns1.eng.sldomain.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <28137a4e39a3ed61511f.1329761242@ns1.eng.sldomain.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Justin T. Gibbs" <justing@spectralogic.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, Feb 20, 2012 at 11:07:22AM -0700, Justin T. Gibbs wrote:
>   o Remove trailing whitespace.
>   o Remove a blank line so that a comment block is adjacent to the
>     code it documents.
> 
> No functional changes.
> 
> Signed-off-by: Justin T. Gibbs <justing@spectralogic.com>

OK, looks good.
> 
> diff -r 87218bd367be -r 28137a4e39a3 xen/include/public/io/blkif.h
> --- a/xen/include/public/io/blkif.h	Fri Feb 17 12:24:38 2012 +0000
> +++ b/xen/include/public/io/blkif.h	Mon Feb 20 10:48:09 2012 -0700
> @@ -1,8 +1,8 @@
>  /******************************************************************************
>   * blkif.h
> - * 
> + *
>   * Unified block-device I/O interface for Xen guest OSes.
> - * 
> + *
>   * Permission is hereby granted, free of charge, to any person obtaining a copy
>   * of this software and associated documentation files (the "Software"), to
>   * deal in the Software without restriction, including without limitation the
> @@ -35,7 +35,7 @@
>   * notification can be made conditional on req_event (i.e., the generic
>   * hold-off mechanism provided by the ring macros). Backends must set
>   * req_event appropriately (e.g., using RING_FINAL_CHECK_FOR_REQUESTS()).
> - * 
> + *
>   * Back->front notifications: When enqueuing a new response, sending a
>   * notification can be made conditional on rsp_event (i.e., the generic
>   * hold-off mechanism provided by the ring macros). Frontends must set
> @@ -133,7 +133,7 @@
>   */
>  #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11
>  
> -/* 
> +/*
>   * NB. first_sect and last_sect in blkif_request_segment, as well as
>   * sector_number in blkif_request, are always expressed in 512-byte units.
>   * However they must be properly aligned to the real sector size of the
> @@ -192,7 +192,6 @@ typedef struct blkif_response blkif_resp
>  /*
>   * Generate blkif ring structures and types.
>   */
> -
>  DEFINE_RING_TYPES(blkif, struct blkif_request, struct blkif_response);
>  
>  #define VDISK_CDROM        0x1
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xensource.com/xen-devel