From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: Append device name in the root debugfs dir
Date: Wed, 22 Feb 2012 13:57:09 +0000 [thread overview]
Message-ID: <20120222135709.GA14766@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1329918783-22610-1-git-send-email-dp@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Wed, Feb 22, 2012 at 01:53:03PM +0000, Dimitris Papastamos wrote:
> void regmap_debugfs_init(struct regmap *map)
> {
> - map->debugfs = debugfs_create_dir(dev_name(map->dev),
> - regmap_debugfs_root);
> + char name[64];
That's a magic number, where did it come from?
> +
> + snprintf(name, sizeof(name), "%s-%s",
> + dev_name(map->dev), map->dev->driver->name);
> +
> + map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
No, keep the directory name the same and add a new file.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-22 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 13:53 [PATCH] regmap: Append device name in the root debugfs dir Dimitris Papastamos
2012-02-22 13:57 ` Mark Brown [this message]
2012-02-22 14:00 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222135709.GA14766@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.