From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0D8O-0007JJ-44
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:25:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0D8I-0000nA-3m
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:25:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29676)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0D8H-0000n4-R9
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:25:26 -0500
Date: Wed, 22 Feb 2012 15:25:17 +0100
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120222142517.GB8461@garlic>
References: <1329860377-6284-1-git-send-email-alevy@redhat.com>
	<1329860377-6284-5-git-send-email-alevy@redhat.com>
	<4F44CD10.2040103@redhat.com>
	<20120222122616.GB607@garlic.redhat.com>
	<4F44F472.6000402@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F44F472.6000402@redhat.com>
Subject: Re: [Qemu-devel] [Spice-devel] [RFC v4 4/9] qxl: screen_dump in
 vga: do a single ppm_save
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: elmarco@redhat.com, yhalperi@redhat.com, qemu-devel@nongnu.org, spice-devel@freedesktop.org

On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote:
> > And the only user of screen_dump_filename is:
> > 
> > static void vga_save_dpy_update(DisplayState *ds,
> >                                 int x, int y, int w, int h)
> > {
> >     if (screen_dump_filename) {
> >         ppm_save(screen_dump_filename, ds->surface);
> 
> upstream/master this here:
> 
>           screen_dump_filename = NULL;
> 

That's wrong, you'll get the screenshot after the first update, who's to
say it is fully rendered?

> >     }
> > }
> 
> > This seems to work, only tested with -vga qxl and in vga mode:
> 
> The corner case where this fails is when console switching is needed,
> i.e. switch to monitor console via ctrl-alt-2, then type the screenshot
> command there ...

Are you talking about sdl console or linux guest console? ctrl-alt-2 or
ctrl-alt-F2? I can try both.

> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel