From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34789)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0E5B-0001Wt-Uz
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:26:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0E53-0003fV-Jv
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:26:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S0E53-0003fC-9h
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 10:26:09 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1MFQ8P5009137
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 22 Feb 2012 10:26:08 -0500
Date: Wed, 22 Feb 2012 16:26:01 +0100
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120222152601.GE8461@garlic>
References: <4F422F5C.9060202@redhat.com> <4F42BB27.6070504@redhat.com>
	<20120221081948.GC6476@garlic> <4F43C331.7090000@redhat.com>
	<20120221174016.GO6476@garlic>
	<20120222111717.0c56390f@doriath.home>
	<20120222132250.GG607@garlic.redhat.com>
	<20120222114927.4c303fd0@doriath.home>
	<20120222142810.GC8461@garlic> <4F44FFEC.6070809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F44FFEC.6070809@redhat.com>
Subject: Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org, elmarco@redhat.com, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Feb 22, 2012 at 03:47:08PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > I was thinking to add a new command since I'll want to add the id, and
> > if I'm already adding a new command I'll put in a display number too.
> 
> Big question is what the display number is supposed to be ...
> 

Ah, yes, it's not specified well enough. So I guess it should actually
be two parameters:
 device path - whatever we are calling it nowadays.
 device specific monitor number (or frame buffer id).

This should be good enough for current 4 pci qxl devices, and future
proof for a single qxl with multiple monitor outputs. Same goes for
s/qxl/any other framebuffer device/, I'm just not sure which are there
(although I'll find out a little by trying out the arm emulater for the
r-pi).

> cheers,
>   Gerd
>