From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 09/10] pwm: Add PXA support Date: Wed, 22 Feb 2012 15:40:16 +0000 Message-ID: <201202221540.16897.arnd@arndb.de> References: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> <1329923841-32017-10-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1329923841-32017-10-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Matthias Kaehlcke , Kurt Van Dijck , Rob Herring , Grant Likely , Colin Cross , Olof Johansson , Richard Purdie , Mark Brown , Mitch Bradley , Mike Frysinger , Eric Miao , Lars-Peter Clausen , Ryan Mallon List-Id: linux-tegra@vger.kernel.org On Wednesday 22 February 2012, Thierry Reding wrote: > > Signed-off-by: Thierry Reding > --- > Changes in v3: > - update PWM ops for changes in patch 2 > > arch/arm/plat-pxa/Makefile | 1 - > arch/arm/plat-pxa/pwm.c | 304 -------------------------------------------- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-pxa.c | 244 +++++++++++++++++++++++++++++++++++ > 5 files changed, 254 insertions(+), 305 deletions(-) > delete mode 100644 arch/arm/plat-pxa/pwm.c > create mode 100644 drivers/pwm/pwm-pxa.c Since most of this patch is a move of one file, it would help to use the -M flag to git-format-patch so we can see the actual change. To make it even more explicit, you could separate the patches that move the files around from the ones that convert the drivers to the new API. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 22 Feb 2012 15:40:16 +0000 Subject: [PATCH v3 09/10] pwm: Add PXA support In-Reply-To: <1329923841-32017-10-git-send-email-thierry.reding@avionic-design.de> References: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> <1329923841-32017-10-git-send-email-thierry.reding@avionic-design.de> Message-ID: <201202221540.16897.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 22 February 2012, Thierry Reding wrote: > > Signed-off-by: Thierry Reding > --- > Changes in v3: > - update PWM ops for changes in patch 2 > > arch/arm/plat-pxa/Makefile | 1 - > arch/arm/plat-pxa/pwm.c | 304 -------------------------------------------- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-pxa.c | 244 +++++++++++++++++++++++++++++++++++ > 5 files changed, 254 insertions(+), 305 deletions(-) > delete mode 100644 arch/arm/plat-pxa/pwm.c > create mode 100644 drivers/pwm/pwm-pxa.c Since most of this patch is a move of one file, it would help to use the -M flag to git-format-patch so we can see the actual change. To make it even more explicit, you could separate the patches that move the files around from the ones that convert the drivers to the new API. Arnd