From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 00/10] Add PWM framework and device tree support. Date: Wed, 22 Feb 2012 16:02:08 +0000 Message-ID: <201202221602.09116.arnd@arndb.de> References: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1329923841-32017-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Matthias Kaehlcke , Kurt Van Dijck , Rob Herring , Grant Likely , Colin Cross , Olof Johansson , Richard Purdie , Mark Brown , Mitch Bradley , Mike Frysinger , Eric Miao , Lars-Peter Clausen , Ryan Mallon List-Id: linux-tegra@vger.kernel.org On Wednesday 22 February 2012, Thierry Reding wrote: > This patch series adds very rudimentary device-tree support for PWM > devices. With all of these patches applied (plus one board-specific > patch that is not included), I'm able to control the backlight on the > device I'm working on using the sysfs interface provided by the pwm-bl > driver and the backlight class. > > This series is based on Sascha Hauer's series of patches[0] to add a > generic PWM framework. The first patch in this series is taken from > Sascha's branch, while the second patch enables each PWM chip to provide > multiple PWM devices (the Blackfin and PXA drivers have been ported to > the framework for reference). When this series is ready I think it would > be best to merge patches 1 and 2. Currently a global namespace is still > provided to keep backwards-compatibility with the legacy PWM API. In > order to achieve this, the number of global PWM devices is limited to > 1024. However, patch 2 introduces per-chip indexing of PWM devices in > the core, so it should be easy to add an API to request a PWM device on > a per-chip basis and get rid of the global namespace eventually. The > device tree support code does not use the global namespace. Hi Thierry, I've just had a chance to look at your series and I think this looks very good overall, great work! I probably wouldn't bother merging patches 1 and 2 as you listed in the TODO section, in order to keep the authorship of each part obvious. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 22 Feb 2012 16:02:08 +0000 Subject: [PATCH v3 00/10] Add PWM framework and device tree support. In-Reply-To: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> References: <1329923841-32017-1-git-send-email-thierry.reding@avionic-design.de> Message-ID: <201202221602.09116.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 22 February 2012, Thierry Reding wrote: > This patch series adds very rudimentary device-tree support for PWM > devices. With all of these patches applied (plus one board-specific > patch that is not included), I'm able to control the backlight on the > device I'm working on using the sysfs interface provided by the pwm-bl > driver and the backlight class. > > This series is based on Sascha Hauer's series of patches[0] to add a > generic PWM framework. The first patch in this series is taken from > Sascha's branch, while the second patch enables each PWM chip to provide > multiple PWM devices (the Blackfin and PXA drivers have been ported to > the framework for reference). When this series is ready I think it would > be best to merge patches 1 and 2. Currently a global namespace is still > provided to keep backwards-compatibility with the legacy PWM API. In > order to achieve this, the number of global PWM devices is limited to > 1024. However, patch 2 introduces per-chip indexing of PWM devices in > the core, so it should be easy to add an API to request a PWM device on > a per-chip basis and get rid of the global namespace eventually. The > device tree support code does not use the global namespace. Hi Thierry, I've just had a chance to look at your series and I think this looks very good overall, great work! I probably wouldn't bother merging patches 1 and 2 as you listed in the TODO section, in order to keep the authorship of each part obvious. Arnd