From: Oleg Nesterov <oleg@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Mandeep Singh Baines <msb@chromium.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] cgroup: Walk task list under tasklist_lock in cgroup_enable_task_cg_list
Date: Wed, 22 Feb 2012 19:03:27 +0100 [thread overview]
Message-ID: <20120222180327.GA11044@redhat.com> (raw)
In-Reply-To: <20120222013339.GG13403@somewhere.redhat.com>
Hi.
Sorry, currently I do not have the time to even read this discussion,
just one note,
On 02/22, Frederic Weisbecker wrote:
>
> On Tue, Feb 21, 2012 at 05:19:34PM -0800, Paul E. McKenney wrote:
> > On Wed, Feb 22, 2012 at 01:55:28AM +0100, Frederic Weisbecker wrote:
> > > On Tue, Feb 21, 2012 at 02:23:43PM -0800, Mandeep Singh Baines wrote:
> > > > Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > > > > Walking through the tasklist in cgroup_enable_task_cg_list() inside
> > > > > an RCU read side critical section is not enough because:
> > > > >
> > > > > - RCU is not (yet) safe against while_each_thread()
Yes. Except I'd say it is while_each_thread() who is not safe ;)
Please do not take this into account. This should be fixed, I hope
to send the fix "soon".
Oleg.
next prev parent reply other threads:[~2012-02-22 18:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 2:37 [RFC][PATCH 0/2] cgroup: Fix some races against css_set task links Frederic Weisbecker
2012-02-08 2:37 ` [PATCH 1/2] cgroup: Remove wrong comment on cgroup_enable_task_cg_list() Frederic Weisbecker
2012-02-08 2:37 ` [PATCH 2/2] cgroup: Walk task list under tasklist_lock in cgroup_enable_task_cg_list Frederic Weisbecker
2012-02-21 22:23 ` Mandeep Singh Baines
2012-02-22 0:55 ` Frederic Weisbecker
2012-02-22 1:00 ` Tejun Heo
2012-02-22 1:04 ` Frederic Weisbecker
2012-02-22 1:06 ` Tejun Heo
2012-02-22 1:10 ` Frederic Weisbecker
2012-02-22 1:19 ` Paul E. McKenney
2012-02-22 1:33 ` Frederic Weisbecker
2012-02-22 18:03 ` Oleg Nesterov [this message]
2012-02-27 18:57 ` Frederic Weisbecker
2012-02-17 5:41 ` [RFC][PATCH 0/2] cgroup: Fix some races against css_set task links Li Zefan
2012-02-21 17:16 ` Tejun Heo
2012-02-21 17:42 ` Frederic Weisbecker
2012-02-21 17:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222180327.GA11044@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.