From: Jurij Smakov <jurij@wooyd.org>
To: sparclinux@vger.kernel.org
Subject: Re: silo trouble with ext3
Date: Wed, 22 Feb 2012 21:47:29 +0000 [thread overview]
Message-ID: <20120222214729.GA4346@wooyd.org> (raw)
In-Reply-To: <alpine.SOC.1.00.1202211523260.24120@math.ut.ee>
On Tue, Feb 21, 2012 at 08:27:33PM -0500, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 21 Feb 2012 18:33:10 -0500 (EST)
>
> > From: David Miller <davem@davemloft.net>
> > Date: Tue, 21 Feb 2012 18:10:07 -0500 (EST)
> >
> >> For example, I just found a bug with symlink handling in path
> >> traversal fixed by the following patch. So if there are symlinks
> >> involved in Meelis's setup that would be the cause rather than not
> >> specifically using ext2 for the boot partition.
> >>
> >> --------------------
> >> ext2: Fix symlink being overwritten.
> >
> > Ignore me, there is no bug. All callers specifically use a special
> > on-stack inode buffer to avoid this problem.
>
> Ok, while waiting for the debug dump from Meelis I think I found the
> problem.
>
> With my test harness I reproduced a case similar to what Meelis saw
> but it has nothing to do with ext3'ness or anything like that.
>
> The block group descriptors were having their location miscalculated.
> It only worked for the first block of group descriptors.
>
> So if an inode is outside of the first several block groups, things
> don't work. I guess for most /boot partitions, which are relatively
> small, most if not all of the files fit into the working range.
>
> Jurij, can you possibly build a test package for Meelis to see if this
> fixes the reported bug?
Sure, a new package with this patch included is available at
http://www.wooyd.org/silo/
Best regards,
--
Jurij Smakov jurij@wooyd.org
Key: http://www.wooyd.org/pgpkey/ KeyID: C99E03CC
next prev parent reply other threads:[~2012-02-22 21:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 13:43 silo trouble with ext3 Meelis Roos
2012-02-21 18:03 ` crn
2012-02-21 19:36 ` David Miller
2012-02-21 19:50 ` David Miller
2012-02-21 22:40 ` David Miller
2012-02-21 22:51 ` Jurij Smakov
2012-02-21 23:10 ` David Miller
2012-02-21 23:33 ` David Miller
2012-02-22 1:27 ` David Miller
2012-02-22 7:22 ` Meelis Roos
2012-02-22 7:26 ` David Miller
2012-02-22 7:32 ` Meelis Roos
2012-02-22 7:45 ` David Miller
2012-02-22 21:47 ` Jurij Smakov [this message]
2012-02-23 6:05 ` mroos
2012-02-23 6:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222214729.GA4346@wooyd.org \
--to=jurij@wooyd.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.