From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] GPIO: LPC32xx: Fix missing bit selection mask
Date: Thu, 23 Feb 2012 09:58:14 +0000 [thread overview]
Message-ID: <201202230958.14801.arnd@arndb.de> (raw)
In-Reply-To: <20120221140259.GB3162@pengutronix.de>
On Tuesday 21 February 2012, Wolfram Sang wrote:
> Show Details
> On Mon, Feb 20, 2012 at 10:39:07PM +0100, Roland Stigge wrote:
> > Add missing mask to pin bit selection in gpio-lpc32xx.c
> > (#define GPIO3_PIN_IN_SEL)
> >
> > A table indentation change was necessary due to line length restrictions, but
> > the only relevant change is the definition of GPIO3_PIN_IN_SEL.
>
> I'd vote for violating the 80 char limit and keep the change minimal
> here, i.e. change only the relevant define.
Yes, that would be better. Another option would be to send two patches, but
I would not bother with that.
Arnd
prev parent reply other threads:[~2012-02-23 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 21:39 [PATCH 1/2] GPIO: LPC32xx: Fix missing bit selection mask Roland Stigge
2012-02-20 21:39 ` [PATCH 2/2] GPIO: LPC32xx: Add output reading to GPO P3 Roland Stigge
2012-02-23 13:40 ` Arnd Bergmann
2012-02-21 14:02 ` [PATCH 1/2] GPIO: LPC32xx: Fix missing bit selection mask Wolfram Sang
2012-02-23 9:58 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202230958.14801.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.