From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RFC: export constants from shpc.h?
Date: Thu, 23 Feb 2012 21:50:54 +0200 [thread overview]
Message-ID: <20120223195053.GB28779@redhat.com> (raw)
In-Reply-To: <20120223085004.17e32327@jbarnes-desktop>
On Thu, Feb 23, 2012 at 08:50:04AM -0800, Jesse Barnes wrote:
> On Thu, 16 Feb 2012 16:54:49 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > I've implemented an shpc controller emulator
> > in qemu, so I needed a bunch of constants
> > similar to what drivers/pci/hotplug/shpc.h has.
> >
> > Any objections to adding a PCI_SHPC_XXXX prefix
> > so these and moving them to pci_regs.h?
> > PCI utilities can then use them from /usr/include/linux.
> >
> > One can see how a utility that looks at slot LED and MRL
> > states might be useful
> > (we'd need to export the base offset through sysfs
> > to make it possible to use such in parallel with shpc).
>
> pci_regs.h is generally reserved for architected regs,
> but maybe a
> separate header file makes sense. Or just patch libpciaccess or
> pci-utils with your tool.
>
> --
> Jesse Barnes, Intel Open Source Technology Center
Fair enough, but out of curiosity,
could you pls clarify what is meant by 'architected'?
SHPC is a PCI-SIG spec after all, not a vecor-specific interface...
next prev parent reply other threads:[~2012-02-23 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 14:54 RFC: export constants from shpc.h? Michael S. Tsirkin
2012-02-23 16:50 ` Jesse Barnes
2012-02-23 19:50 ` Michael S. Tsirkin [this message]
2012-02-23 20:01 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223195053.GB28779@redhat.com \
--to=mst@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.