From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/clvmd/lvm-functions.c
Date: 23 Feb 2012 22:50:50 -0000 [thread overview]
Message-ID: <20120223225050.13671.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-02-23 22:50:50
Modified files:
. : WHATS_NEW
daemons/clvmd : lvm-functions.c
Log message:
Limit sscanf params with size
Make sure parsed string fits given char buffer.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2308&r2=1.2309
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.129&r2=1.130
--- LVM2/WHATS_NEW 2012/02/23 22:41:57 1.2308
+++ LVM2/WHATS_NEW 2012/02/23 22:50:50 1.2309
@@ -1,5 +1,6 @@
Version 2.02.94 -
====================================
+ Limit sscanf parameters with buffer size in clvmd get_initial_state().
Use const lv pointer for lv_is_active...() functions.
Use same signed numbers in _mirrored_transient_status().
Integrate client-side lvmetad into build.
--- LVM2/daemons/clvmd/lvm-functions.c 2012/01/20 00:27:19 1.129
+++ LVM2/daemons/clvmd/lvm-functions.c 2012/02/23 22:50:50 1.130
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2002-2004 Sistina Software, Inc. All rights reserved.
- * Copyright (C) 2004-2011 Red Hat, Inc. All rights reserved.
+ * Copyright (C) 2004-2012 Red Hat, Inc. All rights reserved.
*
* This file is part of LVM2.
*
@@ -729,7 +729,7 @@
}
while (fgets(line, sizeof(line), lvs)) {
- if (sscanf(line, "%s %s %s %s\n", vg, lv, flags, vg_flags) == 4) {
+ if (sscanf(line, "%64s %64s %25s %25s\n", vg, lv, flags, vg_flags) == 4) {
/* States: s:suspended a:active S:dropped snapshot I:invalid snapshot */
if (strlen(vg) == 38 && /* is is a valid UUID ? */
next reply other threads:[~2012-02-23 22:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:50 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 9:54 LVM2 ./WHATS_NEW daemons/clvmd/lvm-functions.c zkabelac
2011-08-10 11:00 mbroz
2011-03-02 23:38 mbroz
2010-07-01 21:23 mbroz
2010-03-24 22:25 snitzer
2010-01-26 8:00 mbroz
2009-12-09 19:01 mbroz
2009-12-09 19:00 mbroz
2009-12-09 18:55 mbroz
2009-12-09 18:45 mbroz
2009-10-22 17:45 agk
2009-10-01 14:14 ccaulfield
2009-08-05 14:18 ccaulfield
2009-03-05 16:25 mbroz
2008-04-08 13:03 ccaulfield
2008-04-04 8:53 ccaulfield
2007-08-24 8:29 pcaulfield
2007-08-23 12:19 pcaulfield
2007-04-24 15:13 pcaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223225050.13671.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.