Re: [PATCH 2/3 v4] arm: kirkwood: add dreamplug (fdt) support.

[Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>]

Hi Jason

Great to see this work going forward. I hope we can cooperating in the
future. I have an out of tree kirkwood board i would like to supported
via DT, and i also have a QNAP T119+ i can use for testing.

I have some patches under development which will help. I've been
porting the different Orion machines to use Mike Turquette generic CLK
and clkdev so that the device drivers can determine for themselves
what the clock is. tclk is then removed from the platform data
structures, making DT a little bit simpler. This work should also
solve the kirkwood clock gating which is going to be an issue for
DT. For example, your board file is probably currently calling
kirkwood_spi_init(), in order to use SPI. This does:

kirkwood_clk_ctrl |= CGC_RUNIT;

and so ensures that the RUNIT clock does not get turned off in a
lateinit call. Once you have DT, this flag is not going to be set, and
so you have the danger of the clock to the SPI core gets turned
off. The clk framework should solve this, since the SPI device driver
will claim the clock and ensure it keeps running.

I'm hoping the next version of Mike Turquette patches get included in
the tree soon, so i can finish my patches for integration.

    Andrew