Re: Using OMAP3 ISP live display and snapshot sample applications

[Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>]

On Thu, Feb 23, 2012 at 07:01:05PM +0200, Ohad Ben-Cohen wrote:
> On Thu, Feb 23, 2012 at 6:59 PM, Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org> wrote:
> > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> > index 609ea2d..f992395 100644
> > --- a/arch/arm/mach-omap2/mailbox.c
> > +++ b/arch/arm/mach-omap2/mailbox.c
> > @@ -412,7 +412,7 @@ static void __exit omap2_mbox_exit(void)
> >        platform_driver_unregister(&omap2_mbox_driver);
> >  }
> >
> > -module_init(omap2_mbox_init);
> > +subsys_initcall(omap2_mbox_init);
> >  module_exit(omap2_mbox_exit);
> >
> >  MODULE_LICENSE("GPL v2");
> 
> And this, too:
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 4e661f0..95adb7e 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1222,7 +1222,7 @@ static int __init omap_iommu_init(void)
> 
>         return platform_driver_register(&omap_iommu_driver);
>  }
> -module_init(omap_iommu_init);
> +subsys_initcall(omap_iommu_init);
> 
>  static void __exit omap_iommu_exit(void)
>  {

These patches make a lot more sense to me than fixing this by relying on
some random linker behavior. Can you please send a fix like this with a
proper commit-msg?

Thanks,

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632