All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: javier Martin <javier.martin@vista-silicon.com>
Cc: alsa-devel@alsa-project.org,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Eric Bénard" <eric@eukrea.com>
Subject: Re: [Q] ASoC: What's the real meaning of SND_SOC_DAIFMT_NB_NF?
Date: Fri, 24 Feb 2012 11:20:39 +0000	[thread overview]
Message-ID: <20120224112039.GA5450@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACKLOr10yUYpMSrebnLvMkc=XQLUXNDxwM+P6U8ysH_Xre3Tmw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]

On Fri, Feb 24, 2012 at 08:53:11AM +0100, javier Martin wrote:

> In the piece of code I've shown to you, when someone configures
> (SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF) he's really selecting an
> active high frame clock when the standard says just the opposite
> (wm8974 datasheet p50).

> If I fixed the bug in the SSI I would break both of them, since I
> would be changing frame clock polarity.

No, with I2S the main effect of inverting the frame clock is to cause a
left/right swap which is a relatively subtle issue, it's not obvious on
an immediate listening test.  It's not really active high or active low
but rather indicating which channel the sample is.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      parent reply	other threads:[~2012-02-24 11:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23 12:40 [Q] ASoC: What's the real meaning of SND_SOC_DAIFMT_NB_NF? javier Martin
2012-02-23 15:19 ` Mark Brown
2012-02-23 15:58   ` javier Martin
2012-02-23 16:14     ` Mark Brown
2012-02-24  7:53       ` javier Martin
2012-02-24  8:34         ` Peter Ujfalusi
2012-02-24 11:05           ` javier Martin
2012-02-24 11:53             ` Mark Brown
2012-02-24 14:09             ` Peter Ujfalusi
2012-02-24 11:20         ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224112039.GA5450@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=eric@eukrea.com \
    --cc=javier.martin@vista-silicon.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.