All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Nikolaj Shurkaev <snnicky@gmail.com>,
	git@vger.kernel.org
Subject: Re: git log -z doesn't separate commits with NULs
Date: Fri, 24 Feb 2012 23:11:04 +0100	[thread overview]
Message-ID: <201202242311.04787.jnareb@gmail.com> (raw)
In-Reply-To: <7vk43cx7c2.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
> > True. That is also a slightly dangerous thing to do, though, because you
> > are omitting full patches in the middle that touch the same paths as the
> > patches you include....
> > ... So
> > perhaps we are better off to refer the user to git-log(1), say that
> > commit limiting options in general would work, but be careful with
> > sending a partial result.
> 
> You seem to have spelled out everything I originally wrote in my reply
> that I later deleted before sending it out, and I think the reason that
> brought you to the three-line conclusion is the same one that made me I
> delete them ;-).
> 
> Using a partial patch essentially has the same risk as cherry-picking a
> commit into different context, and it is a more generic issue that this
> particular manual page should not waste tons of space to teach readers
> about.  I think "Be careful and clueful" is sufficient and the best we can
> do without writing a textbook on distributed software development
> disciplines.

Perhaps git-format-patch should mention that it was created with
path-limited patch in some email pseudo-header like X-Pathspec:
or something, don't you think?

-- 
Jakub Narebski
Poland

  parent reply	other threads:[~2012-02-24 22:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  9:14 git log -z doesn't separate commits with NULs Nikolaj Shurkaev
2012-02-23 10:02 ` Luke Diamand
2012-02-23 10:27   ` Jeff King
2012-02-23 10:17 ` Johannes Sixt
2012-02-23 12:11   ` Nikolaj Shurkaev
2012-02-23 10:24 ` Jeff King
2012-02-23 12:17   ` Nikolaj Shurkaev
2012-02-23 13:15     ` Jakub Narebski
2012-02-23 13:48       ` Nikolaj Shurkaev
2012-02-23 19:34         ` Jeff King
2012-02-23 20:07           ` Junio C Hamano
2012-02-24  9:21             ` Nikolaj Shurkaev
2012-02-24  9:52               ` Jeff King
2012-02-24 20:03                 ` Junio C Hamano
2012-02-24 20:46                   ` Jeff King
2012-02-24 21:14                     ` Junio C Hamano
2012-02-24 21:16                       ` Jeff King
2012-03-03 13:41                         ` Nikolaj Shurkaev
2012-02-24 22:11                       ` Jakub Narebski [this message]
2012-02-24 22:27                         ` Junio C Hamano
2012-02-23 10:35 ` Andreas Schwab
2012-02-23 12:19   ` Nikolaj Shurkaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202242311.04787.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=snnicky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.